Fix standard knob default values for sliders #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela28chen
force-pushed
the
default-max-swap
branch
from
fea79f4 to
3dd7ac4
Compare
wangra-google
approved these changes
Nov 30, 2023
apazylbe
approved these changes
Nov 30, 2023
Keenuts
approved these changes
Dec 1, 2023
angela28chen
force-pushed
the
default-max-swap
branch
from
2fc568a to
e657b1f
Compare
angela28chen
force-pushed
the
default-max-swap
branch
from
e657b1f to
a62c3a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sliders, currently the max values are being used rather than the default values.
Also changing some
int->uint32_tsince those flags cannot be negative