Adds multiview to CubeXr #459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrantComm
force-pushed
the
cubexrmulti
branch
3 times, most recently
from
0a6c0f1 to
a95f45a
Compare
apazylbe
requested changes
May 14, 2024
GrantComm
force-pushed
the
cubexrmulti
branch
3 times, most recently
from
fd23139 to
369de87
Compare
apazylbe
reviewed
Jul 23, 2024
| @@ -269,20 +273,29 @@ void CubeXrApp::Render() | |||
| // Update uniform buffer. | |||
| { | |||
| float t = GetElapsedSeconds(); | |||
| float4x4 P = glm::perspective(glm::radians(60.0f), GetWindowAspect(), 0.001f, 10000.0f); | |||
| float4x4 V = glm::lookAt(float3(0, 0, 0), float3(0, 0, 1), float3(0, 1, 0)); | |||
| float4x4 M = glm::translate(float3(0, 0, -3)) * glm::rotate(t, float3(0, 0, 1)) * glm::rotate(t, float3(0, 1, 0)) * glm::rotate(t, float3(1, 0, 0)); | |||
There was a problem hiding this comment.
Can we rework this logic a bit?
- I am not sure if this currently works with non-XR, we have to make sure it still works
- Can we add a GetCamera(viewIndex) and get the matrices that way, then we wouldn't have to add additional methods to the xr component
| @@ -68,12 +68,12 @@ void CubeXrApp::Setup() | |||
|
|
|||
| // Pipeline | |||
| { | |||
| std::vector<char> bytecode = LoadShader("basic/shaders", "VertexColors.vs"); | |||
| std::vector<char> bytecode = LoadShader("basic/shaders", "VertexColorsMulti.vs"); | |||
There was a problem hiding this comment.
Can you find the spec language that says the view index is going to be 0 if there is not multiview in the shader? Otherwise maybe better to use VertexColors if there is no multiview?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds multiview into Cube_XR. This is a followup to pr#419 where multiview was added to the repo.