Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multisample to foveation app #498

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jorgeag-google
Copy link
Collaborator

@jorgeag-google jorgeag-google commented Jul 29, 2024

Makes the foveation app able to use multisample foveation

This change was missing from the previous PR #493

Copy link
Collaborator

@apazylbe apazylbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run with validation layers? I assume it creates correct multisampled images for render target?

@jorgeag-google
Copy link
Collaborator Author

I run it on device with both methods and saw the foveation pattern working
I run a debug build (on Android) and then look in the logcat and saw no errors.
So I assume it has the validation layers, but not sure

@apazylbe
Copy link
Collaborator

We don't enable validation layers by default on debug Android builds,

#if !defined(NDEBUG) && !defined(PPX_ANDROID)
just cause they take additional steps to set up.
Overall LGTM, I would just double check with validation layers just in case.

@jorgeag-google
Copy link
Collaborator Author

jorgeag-google commented Jul 29, 2024

So, there is a validation error:

VUID-VkSwapchainCreateInfoKHR-compositeAlpha-01280(ERROR / SPEC): msgNum: -1341842926 - Validation Error:
[ VUID-VkSwapchainCreateInfoKHR-compositeAlpha-01280 ] | MessageID = 0xb0051a12 | vkCreateSwapchainKHR(): pCreateInfo->compositeAlpha is not supported, support values are: VK_COMPOSITE_ALPHA_INHERIT_BIT_KHR%s                                                                                                    . The Vulkan spec states: compositeAlpha must be one of the bits present in the supportedCompositeAlpha member of the VkSurfaceCapabilitiesKHR structure returned by vkGetPhysicalDeviceSurfaceCapabilitiesKHR for the surface (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkSwapchainCreateInfoKHR-compositeAlpha-01280)

But there is common to all Android capable applications on the device rather than just the foveation app

@jorgeag-google jorgeag-google merged commit f18d5ef into google:main Jul 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants