Test case 3/4: Disable PS output for ALU and memfetch #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenfengLiu
force-pushed
the
power_consumption
branch
from
46c9309 to
73bf8a5
Compare
| @@ -153,7 +178,10 @@ void FillOutGraphicsPipelineCreateInfo( | |||
| pDstCreateInfo->colorBlendState.blendAttachmentCount = pSrcCreateInfo->outputState.renderTargetCount; | |||
| for (uint32_t i = 0; i < pDstCreateInfo->colorBlendState.blendAttachmentCount; ++i) { | |||
| switch (pSrcCreateInfo->blendModes[i]) { | |||
| default: break; | |||
| case grfx::BLEND_MODE_NONE: { | |||
There was a problem hiding this comment.
might be better to assert for the default case for unknown blend mode
There was a problem hiding this comment.
the -Werror was added to help with this situation, if not all mode was list there, it will be reported as compilation error. However when I tried on windows with /WX option, it seems not working. so added back the default statement here.
RenfengLiu
force-pushed
the
power_consumption
branch
from
a72e6a7 to
ca17cd5
Compare
RenfengLiu
force-pushed
the
power_consumption
branch
from
ca17cd5 to
3073906
Compare
wangra-google
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added knob
disable-ps-outputto disable PS output.For test case 3, use
"fullscreen-quads-type": "Solid_Color"and for test case 4 use"fullscreen-quads-type": "Texture"{
"deterministic": true,
"enable-skybox": false,
"enable-spheres": false,
"enable-metrics": false,
"fullscreen-quads-count": 1,
"fullscreen-quads-type": "Texture",
"fullscreen-quads-single-renderpass": true,
"vs-alu-instruction-count": 100,
"texture-count": 2,
"disable-ps-output": true
}