scale the spheres #535
Merged
scale the spheres #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenfengLiu
force-pushed
the
power_consumption
branch
from
a61cef3 to
fc6c362
Compare
| @@ -53,7 +53,7 @@ float4x4 OrderedGrid::GetModelMatrix(uint32_t sphereIndex, bool isXR) const | |||
| z *= -1.0; | |||
| } | |||
|
|
|||
| return glm::translate(float3(x * mStep, y * mStep, z * mStep)); | |||
| return glm::translate(float3(x * mStep, y * mStep, z * mStep)) * glm::scale(float3(5.f, 5.f, 5.f)); | |||
There was a problem hiding this comment.
This is the effect of 5.0
50 is way too large and can only see the pink/red color
There was a problem hiding this comment.
i feel 5 is still too small as the spheres only covers less than 1/9 of the screen. were you able to see diff in the alpha blending test with scale factor of 5?
There was a problem hiding this comment.
yes, the result posted in the chat is the result of this scale
There was a problem hiding this comment.
my worry is that with 1/9 overage, some difference might be less than noise. how about 20? (so that at least we covers about ~2/3 screen)
Keenuts
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.