Fix failure on missing google.auth inside container #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
commented
Jan 25, 2024
| @@ -5,6 +5,11 @@ addopts = --doctest-modules -v -s | |||
| [pycodestyle] | |||
| ignore = E111,E114 | |||
|
|
|||
| [yapf] | |||
There was a problem hiding this comment.
I added these back so that my emacs autoformat wouldn't clobber the file. Time to switch fully to vs code for python...
littleredcomputer
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a case identified by @georgematheos where
caliban runfails when running in a project wheregoogle-authis not installed. The solution is to usefind_specto check if google.auth is available on the classpath and use it only in that case.