Upgrade Schema library to fix prior formatting issue [don't merge] #64
Conversation
| # problem only occurs for callable validators. | ||
|
|
||
| Directory = s.Or( | ||
| Directory = s.Schema( |
There was a problem hiding this comment.
THIS is the good change that we wanted from this upgrade.
sritchie
force-pushed
the
sritchie/fix_schema
branch
from
0db6b3b to
591c227
Compare
setup.py
Outdated
| 'urllib3>=1.25.7', | ||
| 'yaspin>=0.16.0', | ||
| # This is not a real dependency of ours, but we need it to override the |
There was a problem hiding this comment.
this is incidental, but nice.
caliban/config/__init__.py
Outdated
| s.Optional("gpu", default=list): [str], | ||
| s.Optional("cpu", default=list): [str] | ||
| }, | ||
| s.Schema([str]), |
There was a problem hiding this comment.
this is a problem. We definitely shouldn't have to wrap any compound data structure in Schema to get it to work with a formatting string. If we don't do this, we see:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage ? 52.85%
=======================================
Files ? 33
Lines ? 3557
Branches ? 0
=======================================
Hits ? 1880
Misses ? 1677
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This PR upgrades Schema and fixes a couple of outdated issues with internally defined schemas.