Cost tracking for two-variable comprehensions and bindings #1104
+942
−323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cost tracking for two-variable comprehensions, cel.bind(), and optional_types
This update introduces the concept of a computed entry size for literals which helps
with cost propagation through chained computations. The cost-tracking has cannot
estimate further than one level of nesting within a literal value, but this should be suitable
for most cases.
This change also perform optional and dyn unwrapping, de-emphasizes dynamic size
computations by aggressively caching values though this be improved further for local
variables which require calls into the estimator.
Note, the cost tracking beyond a single level of depth for a literal is quite limited, but considerably improved from its former state.