[Refactor]: This CL refactors a few things in ComponentDescriptor.
#4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_563667275
branch
from
7dab281 to
401ba66
Compare
copybara-service
bot
force-pushed
the
test_563667275
branch
2 times, most recently
from
7003435 to
70d4d74
Compare
copybara-service
bot
force-pushed
the
test_563667275
branch
from
70d4d74 to
5cc209c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Refactor]: This CL refactors a few things in
ComponentDescriptor.abstractmethods inComponentDescriptorto the top of the class so that it's easier to tell which methods contributes to the AutoValue equals/hashcode.ComponentDescriptorFactorydirectly to a nested class,ComponentDescriptor.Factory, to be more consistent with how structure other descriptors likeModuleDescriptor/ModuleDescriptor.Factory.CancellationPolicyclass definition out ofComponentDescriptorsince it's not directly related to that class.RELNOTES=N/A