Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update robolectric dependencies. #4390

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Update robolectric dependencies. #4390

merged 1 commit into from
Aug 13, 2024

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Aug 12, 2024

Update robolectric dependencies.

Our bazel example projects was using an old version of bazel-robolectric (4.1) which referenced an obsolete repository for the robolectric jars "https://repo1.maven.org/central":

https://github.com/robolectric/robolectric-bazel/blob/4.1/bazel/robolectric.bzl#L7

The new repository we're supposed to use is "https://repo1.maven.org/maven2", which is used by bazel-robolectric 4.4+, e.g.:

https://github.com/robolectric/robolectric-bazel/blob/4.4/bazel/robolectric.bzl#L7

This CL updates bazel-robolectric and all robolectric deps to 4.11.1 so that everything is using the same version.

In addition, the above changes ended up breaking other tests (e.g. https://github.com/google/dagger/actions/runs/10360876140/job/28680303187), due to robolectric/robolectric#6593, and required further updating espresso to androidx.test.espresso:espresso-core:3.5.1.

RELNOTES=N/A

@copybara-service copybara-service bot force-pushed the test_662259009 branch 3 times, most recently from 406880a to 81c46fe Compare August 13, 2024 04:37
Our bazel example projects was using an old version of `bazel-robolectric` (4.1) which referenced an obsolete repository for the robolectric jars `"https://repo1.maven.org/central"`:

https://github.com/robolectric/robolectric-bazel/blob/4.1/bazel/robolectric.bzl#L7

The new repository we're supposed to use is `"https://repo1.maven.org/maven2"`, which is used by `bazel-robolectric` 4.4+, e.g.:

https://github.com/robolectric/robolectric-bazel/blob/4.4/bazel/robolectric.bzl#L7

This CL updates `bazel-robolectric` and all robolectric deps to 4.11.1 so that everything is using the same version.

In addition, the above changes ended up breaking other tests (e.g. https://github.com/google/dagger/actions/runs/10360876140/job/28680303187), due to robolectric/robolectric#6593, and required further updating espresso to `androidx.test.espresso:espresso-core:3.5.1`.

RELNOTES=N/A
PiperOrigin-RevId: 662367956
@copybara-service copybara-service bot merged commit f1acd72 into master Aug 13, 2024
@copybara-service copybara-service bot deleted the test_662259009 branch August 13, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant