Remove framework types from multibinding contribution keys. #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_678046562
branch
3 times, most recently
from
31ff368 to
7cf98dc
Compare
This CL removes the framework types from multibinding contribution keys. Before: * `@Provides @IntoMap`: `Map<K,Provider<V>>` * `@Produces @IntoMap`: `Map<K,Producer<V>>` * `@Binds @IntoMap`: (depends on delegating binding) After: * `@Provides @IntoMap`: `Map<K,V>` * `@Produces @IntoMap`: `Map<K,V>` * `@Binds @IntoMap`: `Map<K,V>` I've also added a flag (default enabled) that can be manually disabled to make migrations easier. RELNOTES=N/A PiperOrigin-RevId: 682383786
copybara-service
bot
force-pushed
the
test_678046562
branch
from
7cf98dc to
8ba8242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove framework types from multibinding contribution keys.
This CL removes the framework types from multibinding contribution keys.
Before:
@Provides @IntoMap:Map<K,Provider<V>>@Produces @IntoMap:Map<K,Producer<V>>@Binds @IntoMap: (depends on delegating binding)After:
@Provides @IntoMap:Map<K,V>@Produces @IntoMap:Map<K,V>@Binds @IntoMap:Map<K,V>I've also added a flag (default enabled) that can be manually disabled to make migrations easier.
RELNOTES=N/A