Remove BindingType from BindingGraphFactory resolution logic. #4473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This CL makes a number of changes: * Makes `Binding`'s binding type optional at creation time. * Makes `BindingFactory` set `Optional.empty()` if a binding type cannot be determined from the binding element. * Adds `BindingNode#withBindingType(BindingType)` to allow setting the binding type for certain bindings after they've been created. * Implements `BindingGraphTransformations#withFixedBindingTypes(MutableNetwork)` to fix missing binding types after the network is fully constructed. * Removes the `BindingGraphFactory.Resolver#createDelegateBindings` logic and replace it with `BindingFactory#delegateBinding`. RELNOTES=N/A PiperOrigin-RevId: 684097253
copybara-service
bot
force-pushed
the
test_676112381
branch
from
7a6fca8 to
a03263c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove BindingType from BindingGraphFactory resolution logic.
This CL makes a number of changes:
Binding's binding type optional at creation time.BindingFactorysetOptional.empty()if a binding type cannot be determined from the binding element.BindingNode#withBindingType(BindingType)to allow setting the binding type for certain bindings after they've been created.BindingGraphTransformations#withFixedBindingTypes(MutableNetwork)to fix missing binding types after the network is fully constructed.BindingGraphFactory.Resolver#createDelegateBindingslogic and replace it withBindingFactory#delegateBinding.RELNOTES=N/A