Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @SuppressWarnings("nullness:initialization.field.uninitialized") to component fields. #4499

Merged
merged 1 commit into from
Nov 4, 2024
Merged

add @SuppressWarnings("nullness:initialization.field.uninitialized") to component fields. #4499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion java/dagger/internal/codegen/base/SourceFileGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import static dagger.internal.codegen.javapoet.AnnotationSpecs.Suppression.KOTLIN_INTERNAL;
import static dagger.internal.codegen.javapoet.AnnotationSpecs.Suppression.RAWTYPES;
import static dagger.internal.codegen.javapoet.AnnotationSpecs.Suppression.UNCHECKED;
import static dagger.internal.codegen.javapoet.AnnotationSpecs.Suppression.UNINITIALIZED;
import static dagger.internal.codegen.xprocessing.XElements.closestEnclosingTypeElement;

import androidx.room.compiler.processing.XElement;
Expand Down Expand Up @@ -92,7 +93,7 @@ private JavaFile buildJavaFile(T input, TypeSpec.Builder typeSpecBuilder) {
AnnotationSpecs.suppressWarnings(
ImmutableSet.<Suppression>builder()
.addAll(warningSuppressions())
.add(UNCHECKED, RAWTYPES, KOTLIN_INTERNAL, CAST, DEPRECATION)
.add(UNCHECKED, RAWTYPES, KOTLIN_INTERNAL, CAST, DEPRECATION, UNINITIALIZED)
.build()));

String packageName = closestEnclosingTypeElement(originatingElement).getPackageName();
Expand Down
4 changes: 2 additions & 2 deletions java/dagger/internal/codegen/javapoet/AnnotationSpecs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ public enum Suppression {
FUTURE_RETURN_VALUE_IGNORED("FutureReturnValueIgnored"),
KOTLIN_INTERNAL("KotlinInternal", "KotlinInternalInJava"),
CAST("cast"),
DEPRECATION("deprecation")
;
DEPRECATION("deprecation"),
UNINITIALIZED("nullness:initialization.field.uninitialized");

private final ImmutableList<String> values;

Expand Down
3 changes: 2 additions & 1 deletion javatests/dagger/internal/codegen/GeneratedLines.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ public final class GeneratedLines {
private static final String SUPPRESS_WARNINGS_ANNOTATION =
"@SuppressWarnings({"
+ "\"unchecked\", \"rawtypes\", \"KotlinInternal\", \"KotlinInternalInJava\", \"cast\", "
+ "\"deprecation\""
+ "\"deprecation\","
+ "\"nullness:initialization.field.uninitialized\""
+ "})";

private static final String IMPORT_DAGGER_GENERATED = "import dagger.internal.DaggerGenerated;";
Expand Down
3 changes: 2 additions & 1 deletion javatests/dagger/internal/codegen/ModuleFactoryGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,8 @@ public void kotlinNullableProvides() {
" \"KotlinInternal\",",
" \"KotlinInternalInJava\",",
" \"cast\",",
" \"deprecation\"",
" \"deprecation\",",
" \"nullness:initialization.field.uninitialized\"",
"})",
"public final class TestModule_ProvideStringFactory implements"
+ " Factory<String> {",
Expand Down
3 changes: 2 additions & 1 deletion ...mConflictsWithComponentFieldName_successfulyDeduped_DEFAULT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...onflictsWithComponentFieldName_successfulyDeduped_FAST_INIT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...oldens/AssistedFactoryTest_testAssistedFactoryCycle_DEFAULT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...dens/AssistedFactoryTest_testAssistedFactoryCycle_FAST_INIT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...gen/goldens/AssistedFactoryTest_testAssistedFactory_DEFAULT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...n/goldens/AssistedFactoryTest_testAssistedFactory_FAST_INIT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ssistedFactoryTest_testFactoryGeneratorDuplicatedParamNames_DEFAULT_MODE_test.Foo_Factory
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ import javax.inject.Provider;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
public final class Foo_Factory {
private final Provider<Bar> argProvider;
Expand Down
3 changes: 2 additions & 1 deletion ...istedFactoryTest_testFactoryGeneratorDuplicatedParamNames_FAST_INIT_MODE_test.Foo_Factory
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ import javax.inject.Provider;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
public final class Foo_Factory {
private final Provider<Bar> argProvider;
Expand Down
3 changes: 2 additions & 1 deletion ...Test_testMultipleAssistedFactoryInDifferentComponents_DEFAULT_MODE_test.DaggerMyComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerMyComponent {
private DaggerMyComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...st_testMultipleAssistedFactoryInDifferentComponents_FAST_INIT_MODE_test.DaggerMyComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerMyComponent {
private DaggerMyComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ns/AssistedFactoryTest_testParameterizedAssistParam_DEFAULT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion .../AssistedFactoryTest_testParameterizedAssistParam_FAST_INIT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ns/ComponentBuilderTest_testUsesBuildAndSetterNames_DEFAULT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion .../ComponentBuilderTest_testUsesBuildAndSetterNames_FAST_INIT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ..._compilerMode=DEFAULT_MODE, creatorKind=dagger.Component.Builder_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ..._compilerMode=DEFAULT_MODE, creatorKind=dagger.Component.Factory_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ompilerMode=FAST_INIT_MODE, creatorKind=dagger.Component.Builder_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ompilerMode=FAST_INIT_MODE, creatorKind=dagger.Component.Factory_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ompilerMode=DEFAULT_MODE, creatorKind=dagger.Component.Builder_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ompilerMode=DEFAULT_MODE, creatorKind=dagger.Component.Factory_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...pilerMode=FAST_INIT_MODE, creatorKind=dagger.Component.Builder_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...pilerMode=FAST_INIT_MODE, creatorKind=dagger.Component.Factory_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ompilerMode=DEFAULT_MODE, creatorKind=dagger.Component.Builder_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ompilerMode=DEFAULT_MODE, creatorKind=dagger.Component.Factory_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...pilerMode=FAST_INIT_MODE, creatorKind=dagger.Component.Builder_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...pilerMode=FAST_INIT_MODE, creatorKind=dagger.Component.Factory_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ompilerMode=DEFAULT_MODE, creatorKind=dagger.Component.Builder_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ompilerMode=DEFAULT_MODE, creatorKind=dagger.Component.Factory_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...pilerMode=FAST_INIT_MODE, creatorKind=dagger.Component.Builder_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...pilerMode=FAST_INIT_MODE, creatorKind=dagger.Component.Factory_test.DaggerSimpleComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerSimpleComponent {
private DaggerSimpleComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...goldens/ComponentFactoryTest_testUsesParameterNames_DEFAULT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...ldens/ComponentFactoryTest_testUsesParameterNames_FAST_INIT_MODE_test.DaggerTestComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerTestComponent {
private DaggerTestComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...oldens/ComponentProcessorTest_arrayComponentDependency_DEFAULT_MODE_test.DaggerBComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerBComponent {
private DaggerBComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...dens/ComponentProcessorTest_arrayComponentDependency_FAST_INIT_MODE_test.DaggerBComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerBComponent {
private DaggerBComponent() {
Expand Down
3 changes: 2 additions & 1 deletion ...gen/goldens/ComponentProcessorTest_componentDependency_DEFAULT_MODE_test.DaggerBComponent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import javax.annotation.processing.Generated;
"KotlinInternal",
"KotlinInternalInJava",
"cast",
"deprecation"
"deprecation",
"nullness:initialization.field.uninitialized"
})
final class DaggerBComponent {
private DaggerBComponent() {
Expand Down
Loading
Loading