Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the originating element in LazyMapKeyProxyGenerator. #4529

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

copybara-service[bot]
Copy link

Add the originating element in LazyMapKeyProxyGenerator.

Forgetting the originating element was an oversight. Gradle's incremental processing requires originating elements to determine when to reprocess files. This CL fixes LazyMapKeyProxyGenerator by extending SourceFileGenerator, which takes care of assigning the originating element. In addition, it removes some duplicate code that's already handled in SourceFileGenerator (e.g. adding the generated and suppress annotations).

Fixes #4526

RELNOTES=Fixes #4526: Add the originating element in LazyMapKeyProxyGenerator.

Forgetting the originating element was an oversight. Gradle's incremental processing requires originating elements to determine when to reprocess files. This CL fixes `LazyMapKeyProxyGenerator` by extending `SourceFileGenerator`, which takes care of assigning the originating element. In addition, it removes some duplicate code that's already handled in `SourceFileGenerator` (e.g. adding the generated and suppress annotations).

Fixes #4526

RELNOTES=Fixes #4526: Add the originating element in LazyMapKeyProxyGenerator.
PiperOrigin-RevId: 702869366
@copybara-service copybara-service bot merged commit 5fd8ec1 into master Dec 4, 2024
@copybara-service copybara-service bot deleted the test_702804185 branch December 4, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No dependencies reported for generated source after 2.53 and Kotlin 2.1.0 update
1 participant