Fix warnings about instantiating new boxed primitives. #4539
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_707299930
branch
2 times, most recently
from
1703518 to
3764111
Compare
These constructors are deprecated for removal in upcoming java versions, and are currently giving the following warning:
```
third_party/java_src/dagger/project/javatests/dagger/functional/basic/BasicTest.java:64: warning: [removal] Byte(byte) in Byte has been deprecated and marked for removal
assertThat(basicComponent.getBoxedByte()).isEqualTo(new Byte(BOUND_BYTE));
```
We only call these in a single test and AFAICT they aren't necessary or relevant to what this test is trying to assert so I'm removing them.
RELNOTES=N/A
PiperOrigin-RevId: 707550777
copybara-service
bot
force-pushed
the
test_707299930
branch
from
3764111 to
972c8d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings about instantiating new boxed primitives.
These constructors are deprecated for removal in upcoming java versions, and are currently giving the following warning:
We only call these in a single test and AFAICT they aren't necessary or relevant to what this test is trying to assert so I'm removing them.
RELNOTES=N/A