Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Dagger-genenerated factories to have an additional create method that takes in dagger.internal.Provider types. Since the components already pass in dagger.internal.Provider types, this will automatically make those components use the new method even though the component code hasn't change. #4541

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

copybara-service[bot]
Copy link

Change Dagger-genenerated factories to have an additional create method that takes in dagger.internal.Provider types. Since the components already pass in dagger.internal.Provider types, this will automatically make those components use the new method even though the component code hasn't change.

javax.inject.Provider methods are left to solve linking errors across Dagger versions. These methods will be removed in the future though.

RELNOTES=Make factory classes use dagger.internal.Provider.

…od that takes in `dagger.internal.Provider` types. Since the components already pass in `dagger.internal.Provider` types, this will automatically make those components use the new method even though the component code hasn't change.

`javax.inject.Provider` methods are left to solve linking errors across Dagger versions. These methods will be removed in the future though.

RELNOTES=Make factory classes use `dagger.internal.Provider`.
PiperOrigin-RevId: 707611594
@copybara-service copybara-service bot merged commit d60729d into master Dec 18, 2024
@copybara-service copybara-service bot deleted the test_706772908 branch December 18, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant