Water/Steam Valve Voltage Monitoring #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: bypass_valve_voltage_command bypass_valve_voltage_sensor chilled_water_valve_voltage_command chilled_water_valve_voltage_sensor heat_exchange_supply_water_isolation_valve_voltage_command heat_exchange_supply_water_isolation_valve_voltage_sensor heating_water_valve_voltage_command heating_water_valve_voltage_sensor makeup_water_valve_voltage_command preheating_water_valve_voltage_command steam_valve_voltage_command
Bypass Water Valve Voltage Monitoring
Chilled water valve voltage monitoring.
Heat exchanger supply isolation water valve voltage monitoring.
Heating water valve voltage monitoring.
Make-up water valve voltage monitoring.
Preheating water valve voltage monitoring on supply air side.
Steam valve voltage monitoring.
|
@shambergoldstein Ready for review |
shambergoldstein
requested changes
Oct 29, 2024
shambergoldstein
requested changes
Nov 1, 2024
Corrected to voltage instead of percentage
Added makeup_water_valve_voltage_sensor as a required field
Made voltage_sensor required instead of flowrate_sensor
Added steam_valve_voltage_sensor as a required field
shambergoldstein
requested changes
Nov 5, 2024
| is_abstract: true | ||
| opt_uses: | ||
| - heating_water_flowrate_sensor | ||
| - heating_water_valve_voltage_sensor |
There was a problem hiding this comment.
please make the sensor required
There was a problem hiding this comment.
@shambergoldstein Done
| description: "Bypass water valve voltage monitoring." | ||
| is_abstract: true | ||
| opt_uses: | ||
| - bypass_valve_voltage_sensor |
There was a problem hiding this comment.
please make the sensor required
There was a problem hiding this comment.
@shambergoldstein Done
Made voltage sensor required field
|
@shambergoldstein It looks like this PR will probably fail ontology validation just like the damper-voltage? |
shambergoldstein
requested changes
Jan 28, 2025
| description: "Bypass water valve voltage monitoring." | ||
| is_abstract: true | ||
| opt_uses: | ||
|
|
There was a problem hiding this comment.
please remove the extra line
There was a problem hiding this comment.
@shambergoldstein Done
shambergoldstein
requested changes
Jan 28, 2025
Removed extra line
Added range for steam_valve_voltage_sensor
shambergoldstein
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.