Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Ontology Additions #1496

Merged
merged 23 commits into from
Feb 11, 2025
Merged

Building Ontology Additions #1496

merged 23 commits into from
Feb 11, 2025

Conversation

hhunterr71
Copy link
Contributor

@hhunterr71 hhunterr71 commented Jan 16, 2025

Changes affecting some new subfields, abstracts, and several general types.

@hhunterr71 hhunterr71 changed the title Ontology Additions for US-MTV-1667 Building Ontology Additions Jan 17, 2025
@@ -157,6 +157,17 @@ VAV_SD_DSP_HWZC:
- DSP
- HWZC

VAV_SD_DSP_HWZC_ZSPM:
guid: "c8340b79-25be-43b1-8d4b-afd404d0ebc5"
description: "Single duct reheat VAV with dual setpoint control."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add zone static pressure monitoring to description.


HX_CWDT_PRWDT_CWSISOVPM_CWBYPVPM:
guid: "e8d28beb-539f-404e-9af8-96e9d6926908"
description: 'Condenser/chilled water heat exchanger.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to condenser/process

@@ -118,6 +118,42 @@ HX_CWDT_CHWDT_CWRISOVPM:
- CHWDT
- CWRISOVPM

HX_CWDT_PRWDT_CWSISOVPM:
guid: "6f180176-dde9-4321-a198-9f1ab3d637de"
description: 'Condenser/chilled water heat exchanger.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to condenser/process

@@ -252,6 +252,16 @@ HWS_SWTC_BYPVPM_WDPC_WFRC:
- WDPC
- WFRC

HWS_SWTC_WDPC_BYPVFRC:
guid: "67154932-688a-4c74-b797-62b6c5fa29ae"
description: "Heating water system (temp/pressure control) with bypass control and flow monitoring."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to "with bypass valve flowrate control"

@@ -586,6 +605,19 @@ CHWS_SWTC_WDPC_BYPVFRC_WSEBYPVM_MCBYPVM:
- WSEBYPVM
- MCBYPVM

CHWS_SWTC_WDPC_BYPVFRC_MCBYPVM_MCSWFRM_MMCWDPC:
guid: "a8689543-c41a-4de2-af1f-2005bcb65172"
description: "Chilled water system with differential pressure control, mechanical cooling bypass and waterside economizer bypass."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no WSE bypass

@@ -150,6 +150,19 @@ CDWS_CLPM_SWTC_WDPM_WFRC:
- WDPM
- WFRC

CDWS_SWTC_WDPC_WFRC_RWISOVM_MWFRM_BWFRM:
guid: "d59e0ced-f678-43b0-96cd-8c92951c1cb7"
description: "Condensing water system with supply temperature and flowrate control as well as thermal power and differential pressure control."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no thermal power monitoring


AHU_DFSS_DFVSC_EFSS_EFVSC_DX4DC_ECONM_EDBPC_BSPC_DSPC:
guid: "156e5ec6-5d1f-4571-9857-cf90d0baa1f6"
description: "Multi-zone AHU with exhaust damper monitoring"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more like "exhaust damper building pressure control"

@evgeniya-engel
Copy link
Contributor

@shambergoldstein @ccquigley ready for your review! Thank you!

@hhunterr71
Copy link
Contributor Author

@shambergoldstein This is ready for another review from your comments.

@hhunterr71
Copy link
Contributor Author

@shambergoldstein Ready for review. I removed the Noncanonical type and replaced it with FCU_CSP_DFSS_DXDDC_RMM.

@shambergoldstein shambergoldstein merged commit 2b737ca into google:master Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants