new fields, abstract and canonical types #1504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evgeniya-engel is this ready for review? |
|
@shambergoldstein yes, it's ready now! Thank you! |
shambergoldstein
requested changes
Feb 12, 2025
| @@ -269,3 +269,13 @@ DOAS_SFSS2X_SFVSC2X_EFSS2X_EFVSC2X_DX4SC_EDBPC_SSPC_SARC_VOADM_HTWHLSTC: | |||
| - SARC | |||
| - VOADM | |||
| - HTWHLSTC | |||
|
|
|||
| DOAS_SFSS_DXSC_SSPC: | |||
There was a problem hiding this comment.
Is there any control on the exhaust side?
There was a problem hiding this comment.
There's nothing showing any exhaust, just OA and SA
There was a problem hiding this comment.
@evgeniya-engel Is there no exhaust duct at all or just no damper/fan/anything in it? If there is no duct we should model this as an MAU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.