-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User guide, deployment page: add section 'Deployment on GitHub Pages' #1435
Conversation
The content looks sound from my experience rolling out protobuf.dev. Thanks for the contribution, Andreas! |
Yes, will have a look shortly. |
@chalin: friendly ping |
8f36d9b
to
d34960f
Compare
@chalin: friendly ping again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new GH pages section. I haven't stepped through the process, but overall LGTM. Thanks for your input @Logofile.
There are various ways to configure Netlify. The suggested docs section, which you partially updated, describes only one way. IMHO we shouldn't be telling people how to configure their Netlify accounts, instead we should refer them to the Netlify docs and/or to other resources. Since this is a tangential change and issue to this PR, we can address this later.
I'm aware that the link to the "sample workflow" is invalid. We'll address that separately. There is value in publishing this even if the sample workflow file isn't immediately available. |
This PR adds a new section
Deployment on GitHub Pages
to the deployment page of the user guide.You may have a look at the section preview at Netlify here.
The newly added section also refers to the deployment workfile, to be added to the example site via this PR. Both PRs are closely related and should be reviewed in parallel.
Thir PR also brings some minor corrections and amendments to the section
Deployment with Netlify
.