Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents the body_class parameter #1541

Merged
merged 10 commits into from
Aug 7, 2024

Conversation

fekete-robert
Copy link
Collaborator

@fekete-robert fekete-robert commented Jun 6, 2023

Just ran into that while looking for a way to add custom attributes to the body tag (which doesn't seem to be possible, so I'll open a separate PR for that).

Anyway, this PR documents #774 and fixes #778

@chalin

Preview: https://deploy-preview-1541--docsydocs.netlify.app/docs/adding-content/lookandfeel/#adding-custom-class-to-the-body-element

@fekete-robert
Copy link
Collaborator Author

Thanks a lot for the review, I've updated the doc based on your comments.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @fekete-robert. See inline comments.

userguide/content/en/docs/adding-content/lookandfeel.md Outdated Show resolved Hide resolved
userguide/content/en/docs/adding-content/lookandfeel.md Outdated Show resolved Hide resolved
userguide/content/en/docs/adding-content/lookandfeel.md Outdated Show resolved Hide resolved
@chalin chalin added this to the 24Q3 milestone Aug 5, 2024
@chalin chalin added the user guide Improvements to user guide label Aug 5, 2024
@chalin chalin force-pushed the userguide-document-body-class branch from 8eb6191 to 1d31f97 Compare August 7, 2024 16:25
@chalin chalin force-pushed the userguide-document-body-class branch from 1d31f97 to 4649ce7 Compare August 7, 2024 16:30
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @fekete-robert 🙌🏻

@chalin chalin merged commit 27ff9b6 into google:main Aug 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user guide Improvements to user guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document body_class page param
3 participants