Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more readable deprecation message #482

Merged
merged 1 commit into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/ee/deprecation.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def _IssueAssetDeprecationWarning(asset: DeprecatedAsset) -> None:

warning = (
f'\n\nAttention required for {asset.id}! You are using a deprecated'
' asset.\nTo ensure continued functionality, please update it'
' asset.\nTo make sure your code keeps working, please update it'
)
removal_date = asset.removal_date
today = datetime.datetime.now()
Expand Down
17 changes: 10 additions & 7 deletions python/ee/tests/deprecation_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,33 +94,36 @@
_EXPECTED_WARNINGS = {
'deprecated_asset': (
r'Attention required for deprecated_asset! You are using a deprecated'
r' asset.\nTo ensure continued functionality, please update it.'
r' asset.\nTo make sure your code keeps working, please update it.'
),
'date_and_learn_more': (
r'Attention required for date_and_learn_more! You are using a'
r' deprecated asset.\nTo ensure continued functionality, please update'
r' deprecated asset.\nTo make sure your code keeps working, please'
r' update'
r' it by July 1, 2024.\nLearn more: learn_more_url'
),
'date_only': (
r'Attention required for date_only! You are using a deprecated asset.\n'
r'To ensure continued functionality, please update it by July 1, 2024.'
r'To make sure your code keeps working, please update it by July 1,'
r' 2024.'
),
'two_digit_date': (
r'Attention required for two_digit_date! You are using a deprecated'
r' asset.\nTo ensure continued functionality, please update it by'
r' asset.\nTo make sure your code keeps working, please update it by'
r' July 1, 2024.'
),
'invalid_date': (
r'Attention required for invalid_date! You are using a deprecated'
r' asset.\nTo ensure continued functionality, please update it\.'
r' asset.\nTo make sure your code keeps working, please update it\.'
),
'past_date': (
r'Attention required for past_date! You are using a deprecated'
r' asset.\nTo ensure continued functionality, please update it\.'
r' asset.\nTo make sure your code keeps working, please update it\.'
),
'learn_more_url_only': (
r'Attention required for learn_more_url_only! You are using a'
r' deprecated asset.\nTo ensure continued functionality, please update'
r' deprecated asset.\nTo make sure your code keeps working, please'
r' update'
r' it.\nLearn more: learn_more_url'
),
}
Expand Down
Loading