Resolve a couple of lingering @ResultIgnorabilityUnspecified in EP.

PiperOrigin-RevId: 601091889
google · Jan 26, 2024 · 3948676 · 3948676
1 parent 0be7a89
commit 3948676
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/threadsafety/ThreadSafeChecker.java b/core/src/main/java/com/google/errorprone/bugpatterns/threadsafety/ThreadSafeChecker.java
@@ -84,15 +84,17 @@ public class ThreadSafeChecker extends BugChecker
   // check instantiations of `@ThreadSafe`s in method references
   @Override
   public Description matchMemberReference(MemberReferenceTree tree, VisitorState state) {
-    return checkInvocation(
+    checkInvocation(
         tree, ((JCMemberReference) tree).referentType, state, ASTHelpers.getSymbol(tree));
+    return NO_MATCH;
   }
 
   // check instantiations of `@ThreadSafe`s in method invocations
   @Override
   public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) {
-    return checkInvocation(
+    checkInvocation(
         tree, ASTHelpers.getType(tree.getMethodSelect()), state, ASTHelpers.getSymbol(tree));
+    return NO_MATCH;
   }
 
   @Override
@@ -112,14 +114,12 @@ public Description matchNewClass(NewClassTree tree, VisitorState state) {
     return NO_MATCH;
   }
 
-  private Description checkInvocation(
-      Tree tree, Type methodType, VisitorState state, Symbol symbol) {
+  private void checkInvocation(Tree tree, Type methodType, VisitorState state, Symbol symbol) {
     ThreadSafeAnalysis analysis = new ThreadSafeAnalysis(this, state, wellKnownThreadSafety);
     Violation info = analysis.checkInvocation(methodType, symbol);
     if (info.isPresent()) {
       state.reportMatch(buildDescription(tree).setMessage(info.message()).build());
     }
-    return NO_MATCH;
   }
 
   @Override