Skip to content

Commit

Permalink
Suggest maven-compiler-plugin 3.11.0 in docs
Browse files Browse the repository at this point in the history
I found that with 3.10.1, Error Prone (and NullAway) warnings aren't even printed (!).  Some related discussion at uber/NullAway#830.  I created a relevant sample repo:

https://github.com/msridhar/ep-maven-test-warnings

You can compare running `mvn clean compile` as is with changing [this line](https://github.com/msridhar/ep-maven-test-warnings/blob/main/pom.xml#L23) to be `3.10.1`; with the latter version many fewer warnings are printed, and no Error Prone warnings are printed as far as I can see.

I'm open to adding text that warns users off of versions earlier than 3.11.0 if we think that is warranted.

Fixes #4162

COPYBARA_INTEGRATE_REVIEW=#4162 from msridhar:change-mvn-compiler-plugin-version 4164e56
PiperOrigin-RevId: 578269205
  • Loading branch information
msridhar authored and Error Prone Team committed Oct 31, 2023
1 parent 11edecd commit 47842c6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Edit your `pom.xml` file to add settings to the maven-compiler-plugin:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.10.1</version>
<version>3.11.0</version>
<configuration>
<source>8</source>
<target>8</target>
Expand Down

0 comments on commit 47842c6

Please sign in to comment.