Rip out ImpossibleNullComparison:CheckSwitches flag.

PiperOrigin-RevId: 706035417
google · Dec 14, 2024 · e514b70 · e514b70
1 parent 6195480
commit e514b70
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/ImpossibleNullComparison.java b/core/src/main/java/com/google/errorprone/bugpatterns/ImpossibleNullComparison.java
@@ -151,15 +151,13 @@ private static boolean isNull(ExpressionTree tree) {
   private final boolean matchTestAssertions;
   private final boolean checkPrimitives;
   private final boolean checkValueOf;
-  private final boolean checkSwitches;
 
   @Inject
   ImpossibleNullComparison(ErrorProneFlags flags) {
     this.matchTestAssertions =
         flags.getBoolean("ProtoFieldNullComparison:MatchTestAssertions").orElse(true);
     this.checkPrimitives = flags.getBoolean("ImmutableNullComparison:CheckPrimitives").orElse(true);
     this.checkValueOf = flags.getBoolean("ImpossibleNullComparison:CheckValueOf").orElse(true);
-    this.checkSwitches = flags.getBoolean("ImpossibleNullComparison:CheckSwitches").orElse(true);
   }
 
   @Override
@@ -220,17 +218,13 @@ public ExpressionTree visitTypeCast(TypeCastTree node, Void unused) {
 
     @Override
     public Void visitSwitch(SwitchTree tree, Void unused) {
-      if (checkSwitches) {
-        handleSwitch(tree.getExpression(), tree.getCases());
-      }
+      handleSwitch(tree.getExpression(), tree.getCases());
       return super.visitSwitch(tree, null);
     }
 
     @Override
     public Void visitSwitchExpression(SwitchExpressionTree tree, Void unused) {
-      if (checkSwitches) {
-        handleSwitch(tree.getExpression(), tree.getCases());
-      }
+      handleSwitch(tree.getExpression(), tree.getCases());
       return super.visitSwitchExpression(tree, null);
     }