Support running all available patch checks #4084
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support running all available patch checks
The
BaseErrorProneJavaCompiler
supports running all patch checks; it just requires that one doesn't provide any explicitly named checkers.In practice this doesn't work, however, because:
PatchingOptions
requires a named checker or a custom refactorer.-XepPatchChecks:
without any explicit check will cause the empty string to be stored as a named checker.This PR proposes to resolve the above issues by:
-XepPatchLocation
when-XepPatchChecks
is specified, but not vice versa.-XepPatchChecks:
.Fixes #947
FUTURE_COPYBARA_INTEGRATE_REVIEW=#947 from PicnicSupermarket:bugfix/support-empty-PatchChecks c5d9125