Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running all available patch checks #4084

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link
Contributor

Support running all available patch checks

The BaseErrorProneJavaCompiler supports running all patch checks; it just requires that one doesn't provide any explicitly named checkers.

In practice this doesn't work, however, because:

  • PatchingOptions requires a named checker or a custom refactorer.
  • Specifying -XepPatchChecks: without any explicit check will cause the empty string to be stored as a named checker.

This PR proposes to resolve the above issues by:

  1. Requiring -XepPatchLocation when -XepPatchChecks is specified, but not vice versa.
  2. Omitting empty strings from -XepPatchChecks:.

Fixes #947

FUTURE_COPYBARA_INTEGRATE_REVIEW=#947 from PicnicSupermarket:bugfix/support-empty-PatchChecks c5d9125

@copybara-service copybara-service bot closed this Sep 13, 2023
@copybara-service copybara-service bot deleted the test_564467970 branch September 13, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants