Sniff out internal failures in another way in CompilationTestHelper. #4112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_567340286
branch
from
05df302 to
5430a32
Compare
Stephan202
reviewed
Sep 22, 2023
Comment on lines
316
to
319
| String stringifiedOutput = outputStream.toString(UTF_8); | ||
| assertWithMessage("ErrorProne suffered an internal crash: %s", stringifiedOutput) | ||
| .that(stringifiedOutput) | ||
| .doesNotContain("An exception has occurred in the compiler"); |
There was a problem hiding this comment.
I do see that there is logic below that inspects the result variable in various cases, but (if I read things correctly) not in all code paths. Looking at its possible values, perhaps it would suffice to check for CMDERR, SYSERR and/or ABNORMAL here?
copybara-service
bot
force-pushed
the
test_567340286
branch
from
5430a32 to
5abc8e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sniff out internal failures in another way in CompilationTestHelper.
I had a mysteriously failing test (failing with no diagnostics) which was failing with a
NoSuchMethodErrorin the constructor.I'm not at all sure this is the right fix!