Optionally recommend against static import of Truth8.assertThat
.
#4264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally recommend against static import of
Truth8.assertThat
.The methods there will be moving into the main
Truth
class. Users will have various options for how to migrate, but one option involves avoiding static imports. We will provide more instructions as part of our Truth releases. (See, e.g., the release notes for Truth 1.3.0.)Rough outline of the option that involves avoiding static imports:
Truth8.assertThat(OptionalInt)
(or a similar overload) toTruth
is that anyone who static imports bothTruth.assertThat
andTruth8.assertThat
will see ambiguity errors if they use that method.Truth8.assertThat
. Once all its static imports are gone, we can add the new methods toTruth
without breaking anyone, and then we can migrate users.Truth8.assertThat
would be tough to swallow for the most common types,Stream
andOptional
. Luckily, I found an alternative approach that works for those, as discussed in the linked release notes. (That approach works for those types because they're generic types.)