Test that FieldMissingNullableTest looks at record components when searching for or adding annotations.
#4452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…searching for or adding annotations. (It does.) There is still more that we could do for records, like looking for tests of `someComponent() == null` that use the _method_ `someComponent()` instead of the field. But this seems fine for now, especially since code within the record class is presumably likely to use the field where possible. PiperOrigin-RevId: 647255480
copybara-service
bot
force-pushed
the
test_646986601
branch
from
741a6b4 to
ceb0648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that
FieldMissingNullableTestlooks at record components when searching for or adding annotations.(It does.)
There is still more that we could do for records, like looking for tests of
someComponent() == nullthat use the methodsomeComponent()instead of the field. But this seems fine for now, especially since code within the record class is presumably likely to use the field where possible.