Remove exemption for tests from EmptyCatch #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_673511513
branch
from
552e060 to
e855cc8
Compare
The style guide is being updated in unknown commit. Using `assertThrows` style assertions is now preferred over using try/catch statements for expected exception tests. Startblock: * unknown commit is submitted PiperOrigin-RevId: 674409794
copybara-service
bot
force-pushed
the
test_673511513
branch
from
e855cc8 to
1ff2959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove exemption for tests from EmptyCatch
The style guide is being updated in unknown commit.
Using
assertThrowsstyle assertions is now preferred over using try/catch statements for expected exception tests.Startblock: