Prepare for the removal of TypeTag.UNKNOWN
#4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
The constant was removed as part of https://bugs.openjdk.org/browse/JDK-8339296 This is a minimal fix to avoid breaking for upcoming javac versions. I suspect this logic isn't actually necessary, we aren't supposed to process ASTs with errors and there have been a variety of improvements in how that's handled since this was added. PiperOrigin-RevId: 690616927
copybara-service
bot
force-pushed
the
test_690402997
branch
from
49dfae6 to
d67bc15
Compare
yhkee0404
added a commit
to yhkee0404/woowacourse-java-format
that referenced
this pull request
Nov 8, 2024
6 tasks
github-merge-queue bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Mar 5, 2025
JDK 24 will be released in March, bazel 7.6.x should support it through update of error-prone google/error-prone#4642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for the removal of
TypeTag.UNKNOWNThe constant was removed as part of https://bugs.openjdk.org/browse/JDK-8339296
This is a minimal fix to avoid breaking for upcoming javac versions. I suspect this logic isn't actually necessary, we aren't supposed to process ASTs with errors and there have been a variety of improvements in how that's handled since this was added.