Mark java.time.InstantSource and java.time.Clock as thread safe.
#4724
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_704861086
branch
5 times, most recently
from
2972fb0 to
133f835
Compare
copybara-service
bot
changed the title
java.time.InstantSource as thread safe.java.time.InstantSource and java.time.Clock as thread safe.
Also, annotate `FakeTimeSource` with `@ThreadSafe` to fix breakages caused by marking `InstantSource` as thread safe. `TimeSource` and `common.time.Clock` should also be annotated directly, but we would need to fix or suppress all existing implementations of them first, so I left a TODO instead.
Context: http://yaqs/6914049073339170816
Tested:
TAP for global presubmit queue
[]
PiperOrigin-RevId: 705936781
copybara-service
bot
force-pushed
the
test_704861086
branch
from
133f835 to
83634a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark
java.time.InstantSourceandjava.time.Clockas thread safe.Also, annotate
FakeTimeSourcewith@ThreadSafeto fix breakages caused by markingInstantSourceas thread safe.TimeSourceandcommon.time.Clockshould also be annotated directly, but we would need to fix or suppress all existing implementations of them first, so I left a TODO instead.Context: http://yaqs/6914049073339170816
Tested:
TAP for global presubmit queue
[]