Accept no-op null arguments in ScopedLoggingContext.Builder. #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
All Flogger fluent method calls accept no-op arguments to permit conditionally ignoring a method call without splitting the method chain. While the builder can be assigned to a local variable to conditionally apply methods, this is inconsistent with other usage of Flogger, and discouraged by javadoc. https://google.github.io/flogger/best_practice.html#no-split RELNOTES=Accept no-op null arguments in ScopedLoggingContext.Builder. PiperOrigin-RevId: 557923868
copybara-service
bot
force-pushed
the
test_557574712
branch
from
baf720b to
5aa0649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept no-op null arguments in ScopedLoggingContext.Builder.
All Flogger fluent method calls accept no-op arguments to permit conditionally ignoring a method call without splitting the method chain. While the builder can be assigned to a local variable to conditionally apply methods, this is inconsistent with other usage of Flogger, and discouraged by javadoc.
https://google.github.io/flogger/best_practice.html#no-split
RELNOTES=Accept no-op null arguments in ScopedLoggingContext.Builder.