Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scrollable_positioned_list] Fix manual scrolling accuracy. #469

Merged
merged 2 commits into from
May 2, 2023

Conversation

tarobins
Copy link
Collaborator

@tarobins tarobins commented May 2, 2023

Previously the GestureDetector caused the ScrollablePositionedList to loose a few pixels when scrolling started.

Part of work on #41.

Description

TODO

Related Issues

TODO

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I signed the CLA.
  • All tests from running flutter test pass.
  • flutter analyze does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Previously the GestureDetector caused the ScrollablePositionedList to loose a few pixels when scrolling started.

Part of work on google#41.
@tarobins tarobins merged commit cd51761 into google:master May 2, 2023
@tiagoalvesdulce
Copy link

This PR also fixes #425 and #426 can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants