Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused material import #476

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kturney
Copy link

@kturney kturney commented May 11, 2023

Description

This PR removes an uneccessary import 'package:flutter/material.dart';.
Our projects do not use material, so it would be great for us if scrollable_positioned_list stayed design system agnostic.

I also fixed 2 missing uses of null aware function invocations, without which I could not run tests locally.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I signed the CLA.
  • All tests from running flutter test pass.
  • flutter analyze does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant