-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foldit: Version 1.003 added #5361
Conversation
* Foldit Version 1.003 taken from the upstream repo https://github.com/SophiaDesign/Foldit at commit https://github.com/SophiaDesign/Foldit/commit/.
Fontbakery reportFontbakery version: 0.8.10 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[17] Foldit[wght].ttf🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Note: The following loglevels were omitted in this report:
|
Thanks. I'll upload the designers details after lunch in a new pr. We also need to keep this PR blocked until the latest version of Chrome is out. |
I've sent an email to the designer so that she can provide an image for her profile. I'll create a PR with her information after that. |
@vv-monsalve, sorry I hadn't seen your comment, and I sent a message on instagram to the author. She just added her avatar to the folder. 👌 I can do it if you want, unless you've already started. |
@m4rc1e @vv-monsalve writing here what Rod reported in the chat; the font needs to go through the color script again (missing SVG table) |
Ah, ok, she didn't reply to my email so I haven't started it. If she has provided the image now, yes please you could add her bio ingo if that's ok for you. Thanks |
@m4rc1e Is that something we should do it independently (post-process) or is it already included in fontmake and then cutting a new release would be enough to cover it? |
Pending on support for variations of gradients |
just to clarify once again, "support for variations of gradients" does not mean that the SVG table converted from COLRv1 will contain variations (that's unsupported in the format), simply means maximum_color will henceforth ignore variation data in COLR table when generating the SVG table which will then only contain paths/gradients from the default VF instance. |
@vv-monsalve @m4rc1e I'm working on it right now. Note that since we drop all variations and only leave the default instance in the SVG, the Thin weight will be displayed for those environments that only support OT-SVG and not COLRv1 (e.g. Safari/FireFox, macOS, iOS, Adobe apps etc.). E.g. this is the Finder preview on macOS: If you wanted a more "regular" weight to be shown by default you'd have to change the default master to be the Regular (if there's one, haven't looked at your source). If you are fine with it, never mind ignore my comment. |
/cc @SophiaDesign |
Thanks for the expanded clarification @anthrotype.
Would it mean that the same gradients would be used for the wider-bolder instances? As Dave said in one comment of the issues:
So, would that effect be lost in the resulting VF if the SVG table will contain only the gradients of the font origin?
I don't think this is an issue. |
yes - not just the gradient geometries, the shapes themselves will not vary, SVG simply can't encode OT variations. The rest of the font may be variable, and that's actually a problem because if you select anything other than the Thin instance it will look wrong (outlines of the thin, too wide metrics for the selected non-Thin instance). see googlefonts/nanoemoji#439 (comment) |
There is no Regular master in the source file. It was removed to minimise the file size. Can be added easily if preferred? |
I think this isn't needed because of the reasons provided on the related issues and Marc's comment in the above issue. To my understanding, when he says that is better to leave the font as is this implies:
|
This family remains blocked for technical reasons and should not be moved beyond dev until further notice. It is appropriately labeled |
2820c7c: [gftools-packager] Foldit: Version 1.003 added
Closes #5093