-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gelasio: Version 1.008 added #7308
Conversation
* Gelasio Version 1.008 taken from the upstream repo https://github.com/SorkinType/Gelasio at commit SorkinType/Gelasio@a6ee02d.
FontBakery reportfontbakery version: 0.12.0a2 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [3] Gelasio-Italic[wght].ttf🔥 FAIL: Check tabular widths don't have kerning. (com.google.fonts/check/tabular_kerning)
🔥 FAIL: Ensure the font supports case swapping for all its glyphs. (com.google.fonts/check/case_mapping)
[code: missing-case-counterparts] ℹ INFO: METADATA.pb: Validate family.repository_url field. (com.google.fonts/check/metadata/minisite_url)
[2] Gelasio[wght].ttf🔥 FAIL: Ensure the font supports case swapping for all its glyphs. (com.google.fonts/check/case_mapping)
[code: missing-case-counterparts] ℹ INFO: METADATA.pb: Validate family.repository_url field. (com.google.fonts/check/metadata/minisite_url)
All other checks[12] Gelasio[wght].ttf🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping]
[code: warning-language-shaping] ⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
[12] Gelasio-Italic[wght].ttf🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping]
[code: warning-language-shaping] ⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
Summary
Note: The following loglevels were omitted in this report:
|
FontBakery reportfontbakery version: 0.12.0a2 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [3] Gelasio-Italic[wght].ttf🔥 FAIL: Check tabular widths don't have kerning. (com.google.fonts/check/tabular_kerning)
🔥 FAIL: Ensure the font supports case swapping for all its glyphs. (com.google.fonts/check/case_mapping)
[code: missing-case-counterparts] ℹ INFO: METADATA.pb: Validate family.repository_url field. (com.google.fonts/check/metadata/minisite_url)
[2] Gelasio[wght].ttf🔥 FAIL: Ensure the font supports case swapping for all its glyphs. (com.google.fonts/check/case_mapping)
[code: missing-case-counterparts] ℹ INFO: METADATA.pb: Validate family.repository_url field. (com.google.fonts/check/metadata/minisite_url)
All other checks[12] Gelasio[wght].ttf🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping]
[code: warning-language-shaping] ⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
[12] Gelasio-Italic[wght].ttf🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping]
[code: warning-language-shaping] ⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
Summary
Note: The following loglevels were omitted in this report:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits:
-
Tabular kerns shouldn't exist. Since they're on the ldot, I'm going to let this slide. Let's fix it next release.
-
Is the redesign of the "Eng" ok? I'm guessing this was done for the African expansion. Personally, I would've used the locl feature but what do I know.
old
new
Great VF upgrade btw!
90eb9d2: [gftools-packager] Gelasio: Version 1.008 added
0313ce6: metadatas updated