Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added response.text accessor for Generation Configuration part too #206

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

Shuvo31
Copy link
Contributor

@Shuvo31 Shuvo31 commented Dec 24, 2023

Added response.text accessor for Generation Configuration part too

@Shuvo31 Shuvo31 requested a review from a team as a code owner December 24, 2023 14:26
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Dec 24, 2023
Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

There's too much changed in this PR, it's hard to review.

Could you revert everything except the part you're actually editing, and fllow the formatting instructions in the notebook format workflow?

@MarkDaoust MarkDaoust added status:awaiting user response Awaiting a response from the author and removed status:awaiting review PR awaiting review from a maintainer labels Jan 8, 2024
Shuvo31 and others added 3 commits January 11, 2024 10:01
added response.text accessor for Generation Configuration part too.
@MarkDaoust MarkDaoust merged commit 21c1205 into google:main Jan 11, 2024
4 checks passed
@github-actions github-actions bot removed the status:awaiting user response Awaiting a response from the author label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants