Run nbfmt on notebooks in templates/ #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly so diffs are easy to review in text-mode.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
the
status:awaiting review
Only the nbfmt workflow though - nblint still only operates on site contents.
|
PTAL? @MarkDaoust @pcoet @anirudh161 |
pcoet
approved these changes
Jan 11, 2024
github-actions
bot
removed
the
status:awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add
templates/to the triggers, and runnbfmton notebooks in that dir. They remain excluded fromnblintas they are not site content. And formats the notebooks too.Motivation
Easier text-mode diffs & reviews.
Type of change
Choose one: Other
Checklist
git pull --rebase upstream main).