Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new ipynb notebook to show the Gemini integration with LlamaIndex and Chroma #287

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

dev-nid
Copy link
Contributor

@dev-nid dev-nid commented Mar 6, 2024

Description of the change

Added a new ipynb notebook to show the Gemini integration with LlamaIndex and Chroma

Motivation

Type of change

Other

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@dev-nid dev-nid requested a review from a team as a code owner March 6, 2024 06:22
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Mar 6, 2024
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added a couple of small fixes:

  • pin the llama-index version (resilience against API changes/breaks)
  • clear pip install output
  • and fix up the github link so it renders OK in nbreview.

@markmcd markmcd merged commit da5cfaf into google:main Mar 7, 2024
4 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants