Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading vision.ipynb as part of vision capabilities guide. #453

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

data-wombat
Copy link
Contributor

Uploading vision capabilities Colab as part of DevRel CY

Description of the change

Uploading executable Colab for vision capabilities guide (which is coming shortly).

Motivation

Assigned the vision capabilities guide and wanted an executable Colab for demos

Type of change

Documentation

Checklist

  • [ X] I have performed a self-review of my code.
  • [ X] I have added detailed comments to my code where applicable.
  • [ X] I have verified that my change does not break existing code.
  • [X ] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • [ X] I am familiar with the Google Style Guide for the language I have coded in.
  • [ X] I have read through the Contributing Guide and signed the Contributor License Agreement.

Uploading vision capabilities Colab as part of DevRel CY
@data-wombat data-wombat requested a review from a team as a code owner June 13, 2024 20:45
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Jun 13, 2024
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, I have some very small feedback, but approving now in case changes require syncing with devsite or something and they get done later.

Also FYI I pushed some commits here to fix the buttons & some other small things.

Copy link
Contributor

@pcoet pcoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

site/en/gemini-api/docs/vision.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor Author

@data-wombat data-wombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied requested changes.

@pcoet pcoet merged commit 1f03b5c into google:main Jun 14, 2024
1 check passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants