-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider using a test framework #79
Comments
xyce add mos cv
@atorkmabrains Did we hit this target in the new testing environment we have in PV repo ? |
@FaragElsayed2 I don't believe so. I believe we still use the normal regression flow for PV. I recommend that we open another issue on PV repo and close this one. |
@atorkmabrains Should I do that or wait for @proppy to move it ? |
@FaragElsayed2 Please open the other issue on the PV repo and we I'll close that one. Please make sure to link the new issue to this issue. |
@atorkmabrains Done |
@FaragElsayed2 Could you please link it here? |
@proppy I'm closing this issue as we moved it to PV repo as @FaragElsayed2 has highlighted above. |
Expected Behavior
Tests should be using python testing best practices.
One popular framework is
pytest
: https://docs.pytest.org/en/7.2.x/ as it comes with:Actual Behavior
Tests uses monolytics python scripts with manual
exit()
invocation, see https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/main/rules/klayout/drc/testing/run_regression.py#L243The text was updated successfully, but these errors were encountered: