Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding lvs_bjt table for GF180MCU DRC #50

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Adding lvs_bjt table for GF180MCU DRC #50

merged 1 commit into from
Mar 30, 2023

Conversation

FaragElsayed2
Copy link
Collaborator

Adding lvs_bjt table for GF180MCU DRC

Fixes #43

@FaragElsayed2
Copy link
Collaborator Author

@atorkmabrains Ready to review

proppy
proppy approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@proppy proppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits comments and questions, but nothing blocking

@atorkmabrains
Copy link
Collaborator

@proppy Could you please merge?

@proppy
Copy link
Member

proppy commented Mar 30, 2023

@proppy Could you please merge?

Sure, I just needed to find some time to file issue for the items that were raised during the review, sorry for the delay!

@proppy proppy merged commit 22164ad into google:main Mar 30, 2023
@atorkmabrains atorkmabrains deleted the lvs_bjt_google branch March 30, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proppy proppy proppy approved these changes

@atorkmabrains atorkmabrains Awaiting requested review from atorkmabrains

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating PRs for each DRC table separately
3 participants
@FaragElsayed2 @atorkmabrains @proppy