Adding MCELL table for GF180MCU DRC #60
Conversation
|
@atorkmabrains I have no access to ask for review in this repo, could you please review all PRs ? |
|
@FaragElsayed2 - I have sent you an invite which should enable you to request reviews / add labels / etc. |
|
Thanks @mithro, but I didn't receive any invitation for this user @FaragElsayed2. Could you please check again ? |
|
Looks like I accidentally invited FaragElsayed22, should be fixed now. |
|
I received it. Thanks @mithro |
|
@atorkmabrains can you review it first? |
|
|
||
| # Rule MC.3: Minimum Mcell area is 0.35µm² | ||
| logger.info('Executing rule MC.3') | ||
| mc3_l1 = mcell_feol_mk.with_area(nil, 0.35.um) |
There was a problem hiding this comment.
same comment as #54 but non blocking.
|
|
||
| # Rule MC.4: Minimum area enclosed by Mcell is 0.35µm² | ||
| logger.info('Executing rule MC.4') | ||
| mc4_l1 = mcell_feol_mk.holes.with_area(nil, 0.35.um) |
There was a problem hiding this comment.
same comment as #54 but non blocking.
| @@ -0,0 +1,184 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
it's nice to see the failing test on the left and the passing test on the right!
is that a consistent convention across all rules, should we document it?
There was a problem hiding this comment.
We try to do this, but not always.
| # limitations under the License. | ||
| ################################################################################################ | ||
|
|
||
| if FEOL |
There was a problem hiding this comment.
same comment as #58 but non blocking.
| mc1_l1 = mcell_feol_mk.width(0.4.um, euclidian) | ||
| mc1_l1.output('MC.1', 'MC.1 : min. mcell width : 0.4µm') | ||
| mc1_l1.forget | ||
|
|
There was a problem hiding this comment.
same comment as #53 but non blocking.
| if FEOL | ||
| #================================================ | ||
| #---------------------MCELL---------------------- | ||
| #================================================ |
There was a problem hiding this comment.
same comment at #57, it would be nice to link to https://gf180mcu-pdk.readthedocs.io/en/latest/physical_verification/design_manual/drm_07_18.html#mcell but non blocking.
|
Thanks @proppy |
Adding MCELL table for GF180MCU DRC
Fixes #43