-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SRAM3p3 table for GF180MCU DRC #61
Conversation
@atorkmabrains can you review it first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FaragElsayed2
# limitations under the License. | ||
################################################################################################ | ||
|
||
if FEOL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#58 but not blocking
if FEOL | ||
|
||
#================================================ | ||
#-------------------3.3V SRAM-------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#57 but not blocking
sdf4c_l1.forget | ||
sdf4c_l2.forget | ||
sdf4c_l.forget | ||
pcomp_out_dn_sram.forget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#53 but not blocking
# Rule S.DF.4c_LV: Min. (Nwell overlap of PCOMP) outside DNWELL is 0.4µm. | ||
logger.info('Executing rule S.DF.4c_LV') | ||
pcomp_out_dn_sram = pcomp.outside(dnwell).and(sram_lv) | ||
sdf4c_l1 = pcomp_out_dn_sram.enclosed(nw_n_dn_sram, 0.4.um, euclidian).polygons(0.001.um) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have .001
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed #66 to discuss this further
|
||
# Rule S.CO.3_LV: Poly2 overlap of contact is 0.04µm. | ||
logger.info('Executing rule S.CO.3_LV') | ||
sco3_l1 = contact_sram.enclosed(poly_sram, 0.04.um, euclidian).polygons(0.001.um) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have .001
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed #66 to discuss this further
|
||
# Rule S.CO.4_LV: COMP overlap of contact is 0.03µm. | ||
logger.info('Executing rule S.CO.4_LV') | ||
sco4_l1 = comp_sram.enclosing(contact_sram, 0.03.um, euclidian).polygons(0.001.um) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have .001
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed #66 to discuss this further
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some nits and questions but nothing blocking per se, I'll leave it up to you if you want to address those in this PR or file separate issues to track them.
@proppy I have answered all your questions in other PRs. |
Adding SRAM3p3 table for GF180MCU DRC
Fixes #43