-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding NAT table for GF180MCU DRC #71
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FaragElsayed2
# frozen_string_literal: true | ||
|
||
################################################################################################ | ||
# Copyright 2022 GlobalFoundries PDK Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same @FaragElsayed2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do that for all DRC files in a separate PR after adding all tables.
Refer to #75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FaragElsayed2
@proppy Could you please merge this? |
|
||
if CONNECTIVITY_RULES | ||
logger.info('CONNECTIVITY_RULES section') | ||
_connected_nat, unconnected_nat = conn_space(natcomp, 10, 10, transparent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we use an _
here? should we forget
them after use too?
|
||
if CONNECTIVITY_RULES | ||
logger.info('CONNECTIVITY_RULES section') | ||
_connected_nat, unconnected_nat = conn_space(natcomp, 10, 10, transparent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is conn_space
an helper method defined somewhere else?
# Rule NAT.6: Two or more COMPs if connected to different potential | ||
## are not allowed under same NAT layer. | ||
logger.info('Executing rule NAT.6') | ||
nat6_l1 = comp.and(nat).interacting(unconnected_nat.inside(nat.covering(comp, 2)).not(poly2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why the not(poly2)
is necessary here (since it's not part of the wording of the rule)
|
||
# Rule NAT.8: Min. Dualgate overlap of NAT (for 5V/6V) native VT NMOS only is 0um. | ||
logger.info('Executing rule NAT.8') | ||
nat8_l1 = nat.not_outside(dualgate).not(dualgate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't nat.and(dualgate)
be enough?
# Rule NAT.9: Poly interconnect under NAT layer is not allowed, | ||
## minimum spacing of un-related poly from the NAT layer is 0.3um. | ||
logger.info('Executing rule NAT.9') | ||
nat9_a = poly_nat.not(ncomp).interacting(ngate.and(nat), 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that for the first part of the rule Poly interconnect under NAT layer is not allowed
?
@@ -0,0 +1,2 @@ | |||
nat: | |||
--variant: "C --connectivity" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that new should we also add it in #73 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some nits and questions.
Thanks for the hard work on this, and sorry about the late review. |
Adding NAT table for GF180MCU DRC