You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For whoever picks this up, remember to add the new service here and to move the RateLimits tests from github_test.go to ratelimit_test.go.
There will be a small decline in test coverage because the newly deprecated Client method is no longer tested. The decreased test coverage will cause a failure status on your PR, but that can safely be ignored as long as the decreased coverage is only the Client method.
I missed the RateLimits method in #2937. It should be moved to a service struct.
Docs are at rate-limit/rate-limit#get-rate-limit-status-for-the-authenticated-user, so according to our existing pattern, we should move it to a new service called
RateLimitService
and name itGet
Client.RateLimits
should be marked as deprecated and its body should be updated toreturn c.RateLimit.Get(ctx)
This may be a candidate for "good first issue" with the slight complication of creating a new service.
/cc #2936
The text was updated successfully, but these errors were encountered: