Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RateLimits method to a service #2969

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Move RateLimits method to a service #2969

merged 2 commits into from
Oct 20, 2023

Conversation

nhAnik
Copy link
Contributor

@nhAnik nhAnik commented Oct 20, 2023

Closes #2968

@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #2969 (64bfb14) into master (56ca0e5) will decrease coverage by 0.02%.
The diff coverage is 97.95%.

@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
- Coverage   98.13%   98.11%   -0.02%     
==========================================
  Files         148      149       +1     
  Lines       12787    12790       +3     
==========================================
+ Hits        12548    12549       +1     
- Misses        164      166       +2     
  Partials       75       75
Files Coverage Δ
github/rate_limit.go 100.00% <100.00%> (ø)
github/github.go 97.71% <50.00%> (-0.41%) ⬇️

gmlewis
gmlewis reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nhAnik !
Anywhere you find client.RateLimits (such as test/integration/misc_test.go), it needs to be updated to call the new service instead.

WillAbides
WillAbides reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@WillAbides WillAbides left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM except for the lint failure. You can fix that by calling your new method instead of client.RateLimits

edit: looks like @gmlewis beat me to it :)

WillAbides
WillAbides approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@WillAbides WillAbides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmlewis
gmlewis approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nhAnik and @WillAbides !
LGTM.
Merging.

@gmlewis gmlewis merged commit eea6e0a into google:master Oct 20, 2023
5 of 7 checks passed
@gmlewis gmlewis mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@WillAbides WillAbides WillAbides approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move RateLimits method to a service
3 participants
@nhAnik @WillAbides @gmlewis