Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/PuerkitoBio/goquery from 1.9.2 to 1.10.0 in /scrape #3260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 9, 2024

Bumps github.com/PuerkitoBio/goquery from 1.9.2 to 1.10.0.

Release notes

Sourced from github.com/PuerkitoBio/goquery's releases.

v1.10.0

Add EachIter which provides an iterator that can be used in for..range loops on the *Selection object.

goquery now requires Go version 1.23+, use goquery v1.9.x for older Go versions.

v1.9.3

Update go.mod dependencies.

Commits
  • 7d37930 Update readme to prepare 1.10 version
  • 9551ee5 Merge pull request #489 from PuerkitoBio/amikai-itereach-pr
  • 291e2cf Merge branch 'master' into amikai-itereach-pr
  • 7019296 Update CI to target go1.23+
  • eec8e87 Revert "Re-orangize code for compitable"
  • 957a864 Prepare 1.9.3 release
  • 34d91db Merge pull request #488 from PuerkitoBio/dependabot/go_modules/golang.org/x/n...
  • 0984c44 Bump golang.org/x/net from 0.28.0 to 0.29.0
  • fbfb78c Merge pull request #487 from Kiyo510/fix_ci_test
  • e91ee4d Fixed checkout to repo before executing actions/setup-go@v5 step to avoid err...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 9, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 9, 2024

Running this locally shows that we would lose support for Go 1.22 if we bump this version now:

$ GOTOOLCHAIN=go1.21.6 go mod tidy -compat=1.21
go: github.com/PuerkitoBio/[email protected] requires go >= 1.23 (running go 1.21.6; GOTOOLCHAIN=go1.21.6)

Therefore, I'm putting this change on hold.

@gmlewis gmlewis added the DO NOT MERGE Do not merge this PR. label Sep 9, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/scrape/github.com/PuerkitoBio/goquery-1.10.0 branch from 2cf307e to cc5ed8c Compare September 16, 2024 13:38
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 16, 2024

@dependabot recreate

Bumps [github.com/PuerkitoBio/goquery](https://github.com/PuerkitoBio/goquery) from 1.9.2 to 1.10.0.
- [Release notes](https://github.com/PuerkitoBio/goquery/releases)
- [Commits](PuerkitoBio/goquery@v1.9.2...v1.10.0)

---
updated-dependencies:
- dependency-name: github.com/PuerkitoBio/goquery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/scrape/github.com/PuerkitoBio/goquery-1.10.0 branch from cc5ed8c to 927ab1a Compare September 16, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file DO NOT MERGE Do not merge this PR. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant