-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Add support for Issue Types API #3525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
…add validation Unified the CreateHostedRunnerRequest and UpdateHostedRunnerRequest into a single HostedRunnerRequest struct. Added validation functions for HostedRunnerRequest. Signed-off-by: atilsensalduz <[email protected]>
…add validation Unified the CreateHostedRunnerRequest and UpdateHostedRunnerRequest into a single HostedRunnerRequest struct. Added validation functions for HostedRunnerRequest. Signed-off-by: atilsensalduz <[email protected]>
…add validation Unified the CreateHostedRunnerRequest and UpdateHostedRunnerRequest into a single HostedRunnerRequest struct. Added validation functions for HostedRunnerRequest. Signed-off-by: atilsensalduz <[email protected]>
…text, allowing for better error inspection and unwrapping. Signed-off-by: atilsensalduz <[email protected]>
…text, allowing for better error inspection and unwrapping. Signed-off-by: atilsensalduz <[email protected]>
- Implement functions to interact with the Issue Types API: - ListIssueTypes: Retrieve all issue types for an organization. - CreateIssueType: Add a new issue type to an organization. - UpdateIssueType: Modify an existing issue type. - DeleteIssueType: Remove an issue type from an organization. - Add corresponding tests for each function to ensure reliability. References: - GitHub REST API documentation: https://docs.github.com/en/rest/orgs/issue-types - Related issue: #3523 Signed-off-by: atilsensalduz <[email protected]>
- Implement functions to interact with the Issue Types API: - ListIssueTypes: Retrieve all issue types for an organization. - CreateIssueType: Add a new issue type to an organization. - UpdateIssueType: Modify an existing issue type. - DeleteIssueType: Remove an issue type from an organization. - Add corresponding tests for each function to ensure reliability. References: - GitHub REST API documentation: https://docs.github.com/en/rest/orgs/issue-types - Related issue: #3523 Signed-off-by: atilsensalduz <[email protected]>
- Implement functions to interact with the Issue Types API: - ListIssueTypes: Retrieve all issue types for an organization. - CreateIssueType: Add a new issue type to an organization. - UpdateIssueType: Modify an existing issue type. - DeleteIssueType: Remove an issue type from an organization. - Add corresponding tests for each function to ensure reliability. References: - GitHub REST API documentation: https://docs.github.com/en/rest/orgs/issue-types - Related issue: #3523 Signed-off-by: atilsensalduz <[email protected]>
- Implement functions to interact with the Issue Types API: - ListIssueTypes: Retrieve all issue types for an organization. - CreateIssueType: Add a new issue type to an organization. - UpdateIssueType: Modify an existing issue type. - DeleteIssueType: Remove an issue type from an organization. - Add corresponding tests for each function to ensure reliability. References: - GitHub REST API documentation: https://docs.github.com/en/rest/orgs/issue-types - Related issue: #3523 Signed-off-by: atilsensalduz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3525 +/- ##
==========================================
+ Coverage 91.27% 91.30% +0.02%
==========================================
Files 183 184 +1
Lines 16099 16143 +44
==========================================
+ Hits 14695 14739 +44
Misses 1230 1230
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It looks like the openapi stuff is a problem afterall. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @atilsensalduz!
Just one minor tweak, please.
- Implement functions to interact with the Issue Types API: - ListIssueTypes: Retrieve all issue types for an organization. - CreateIssueType: Add a new issue type to an organization. - UpdateIssueType: Modify an existing issue type. - DeleteIssueType: Remove an issue type from an organization. - Add corresponding tests for each function to ensure reliability. References: - GitHub REST API documentation: https://docs.github.com/en/rest/orgs/issue-types - Related issue: #3523 Signed-off-by: atilsensalduz <[email protected]>
Tests are passed in my local. @gmlewis could you please rerun the test? wdyt to add small delay in here?
before: after: |
What I would really like to understand is WHY we have any race conditions at all. |
- Implement functions to interact with the Issue Types API: - ListIssueTypes: Retrieve all issue types for an organization. - CreateIssueType: Add a new issue type to an organization. - UpdateIssueType: Modify an existing issue type. - DeleteIssueType: Remove an issue type from an organization. - Add corresponding tests for each function to ensure reliability. References: - GitHub REST API documentation: https://docs.github.com/en/rest/orgs/issue-types - Related issue: #3523 Signed-off-by: atilsensalduz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @atilsensalduz and @Wisma-55!
LGTM.
Merging.
This pull request introduces support for the Issue Types API to the
go-github
library, enabling users to manage issue types within their organizations. The following functions have been added:Each function is accompanied by comprehensive tests to ensure functionality and reliability.
API References: https://docs.github.com/en/rest/orgs/issue-types
Fixes: #3523
Please let me know if any additional changes or improvements are needed!